Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using viewport relative coordinate #4801

Merged
merged 6 commits into from Nov 2, 2023

Conversation

tisilent
Copy link
Contributor

fix #4799

@tisilent
Copy link
Contributor Author

Stuck while writing regression tests.
general
await ctx.value.proxy.resize(20, 10); await ctx.value.proxy.resize(50, 20); await ctx.value.proxy.scrollToBottom(); await ctx.value.proxy.scrollLines(-2); await ctx.value.proxy.blur();
Scrollbar not displayed.

@Tyriar
Copy link
Member

Tyriar commented Sep 14, 2023

@tisilent I wouldn't have thought you'd need to see the scroll bar for this? Did you write enough text to full the viewport so scrollLines(-2) does something?

@Tyriar Tyriar added this to the 5.4.0 milestone Sep 25, 2023
@Tyriar Tyriar self-assigned this Nov 2, 2023
@Tyriar Tyriar enabled auto-merge November 2, 2023 18:16
@Tyriar Tyriar merged commit a5646a5 into xtermjs:master Nov 2, 2023
19 checks passed
@tisilent tisilent deleted the fix-inactive-cursor-spot branch November 3, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webgl renderer: Inactive cursor can render in the wrong spot
2 participants