Allow xterm.js to run on legacy versions of Safari when Webgl2 support is explicitly enabled #4836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On older versions of iOS and iPadOS, WebKit rendering engine the only option for Safari and all third-party browsers. Running xterm.js on these devices is currently impossible, even if the user has enabled Webgl2 support in
Settings - Safari - Advanced - Experimental Features.This pull request adds an extra check on devices with legacy version of Safari in
WebglAddon.tsthat determines the actual capability of running Webgl2 on the device, so users who have enabled Webgl2 can use xterm.js without any troubles.