Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle selection when resizing #4837

Merged
merged 4 commits into from Nov 2, 2023
Merged

handle selection when resizing #4837

merged 4 commits into from Nov 2, 2023

Conversation

tisilent
Copy link
Contributor

fix #4764 .

Want to use SelectionRenderModel.

@Tyriar Tyriar added this to the 5.4.0 milestone Nov 2, 2023
@Tyriar Tyriar self-assigned this Nov 2, 2023
@Tyriar Tyriar merged commit 4036ab7 into xtermjs:master Nov 2, 2023
19 checks passed
@tisilent tisilent deleted the fix-dom-renderer-selection branch November 3, 2023 01:59
@tisilent
Copy link
Contributor Author

tisilent commented Nov 3, 2023

I can try applying CellColorResolver .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.

DOM renderer abnormal resizing after selection
2 participants
@tisilent @Tyriar