Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proper isNode detection for node v21.0.0 #4851

Merged
merged 2 commits into from Oct 19, 2023

Conversation

davidfiala
Copy link
Contributor

Fix for #4850

Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@Tyriar Tyriar added this to the 5.4.0 milestone Oct 19, 2023
@Tyriar Tyriar enabled auto-merge October 19, 2023 18:10
@Tyriar Tyriar self-assigned this Oct 19, 2023
We provide no further type information as it will not be used except for a presence check for nodejs detection.
auto-merge was automatically disabled October 19, 2023 18:19

Head branch was pushed to by a user without write access

@Tyriar Tyriar enabled auto-merge October 19, 2023 18:29
@Tyriar Tyriar merged commit 9fff1e6 into xtermjs:master Oct 19, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants