Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update devcontainer #4865

Merged
merged 3 commits into from
Apr 21, 2024
Merged

Update devcontainer #4865

merged 3 commits into from
Apr 21, 2024

Conversation

silamon
Copy link
Contributor

@silamon silamon commented Nov 4, 2023 •
edited

Updates the devcontainer to use Node 18 where it wasn't the case yet.

  • Ensure that devcontainer doesn't install Node 18 and Node 20 (where of the last has become lts as well)
  • Bumps jsdoc to latest version (this already adds support for node 20)
  • Use bookworm instead of buster
  • Remove references where Node 16 is still used
  • adds "yarn setup" to create devcontainer command

@silamon silamon changed the title Update Devcontainer Update devcontainer Mar 22, 2024
@Tyriar Tyriar added this to the 5.6.0 milestone Apr 21, 2024
@Tyriar Tyriar self-assigned this Apr 21, 2024
@Tyriar Tyriar merged commit bada1d2 into xtermjs:master Apr 21, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
5.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@silamon @Tyriar