Update required eslint and eslint-plugin-jsdoc versions #4930

PerBothner · 2023-12-30T02:15:43Z

This fixes a problem when using node 20.x.x, because eslint-plugin-jsdoc@39.9.1 requires node version "^14 || ^16 || ^17 || ^18 || ^19".

$ node --version
v20.10.0
$ yarn
yarn install v1.22.10
[1/4] Resolving packages...
[2/4] Fetching packages...
info fsevents@2.3.2: The platform "linux" is incompatible with this module.
info "fsevents@2.3.2" is an optional dependency and failed compatibility check. Excluding it from installation.
error eslint-plugin-jsdoc@39.9.1: The engine "node" is incompatible with this module. Expected version "^14 || ^16 || ^17 || ^18 || ^19". Got "20.10.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

This fixes a problem when using node 20.*.*, because eslint-plugin-jsdoc@39.9.1 requires node version "^14 || ^16 || ^17 || ^18 || ^19".

Update required eslint and eslint-plugin-jsdoc versions

a7bf3b2

This fixes a problem when using node 20.*.*, because eslint-plugin-jsdoc@39.9.1 requires node version "^14 || ^16 || ^17 || ^18 || ^19".

Tyriar approved these changes Dec 30, 2023

View reviewed changes

Tyriar added this to the 5.4.0 milestone Dec 30, 2023

Tyriar merged commit b97baa7 into xtermjs:master Dec 30, 2023
16 checks passed

PerBothner deleted the update-eslint branch December 30, 2023 17:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update required eslint and eslint-plugin-jsdoc versions #4930

Update required eslint and eslint-plugin-jsdoc versions #4930

PerBothner commented Dec 30, 2023 •

edited

Update required eslint and eslint-plugin-jsdoc versions #4930

Update required eslint and eslint-plugin-jsdoc versions #4930

Conversation

PerBothner commented Dec 30, 2023 • edited

PerBothner commented Dec 30, 2023 •

edited