Speed up insertion and deletion of values in SortedList by batching and deferring to idle task #5038
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4911
Test setup:
Before:
Insert ~4s
Delete ~4s
After:
Insert ~330ms
Delete ~93ms
There's still a decent amount of GC happening on insert, but a lot of it has to happen due to the variables being used in callbacks. It's reasonable when you consider it's 200000 decorations.