Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up tsconfig.json. #586

Merged
merged 2 commits into from
Mar 8, 2017
Merged

Conversation

AndrienkoAleksandr
Copy link
Contributor

'include' field in the tsconfig.json defines source scope (top level of this scope is "src" folder), so we do not need 'exclude' folders in the root of the project, because this folders had already excluded by 'include' scope.

Signed-off-by: Aleksandr Andrienko aandrienko@codenvy.com

'include' field in the tsconfig.json defines source scope (top level of this scope is "src" folder), so we do not need 'exclude' folders in the root of the project, because this folders had already excluded by 'include' scope.

Signed-off-by: Aleksandr Andrienko <aandrienko@codenvy.com>
@coveralls
Copy link

Coverage Status

Coverage decreased (-7.3%) to 60.475% when pulling 3d721a9 on AndrienkoAleksandr:cleanUpTsConfig into c9ad3a5 on sourcelair:master.

Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's merge this in for 2.5 👍

@Tyriar Tyriar self-assigned this Mar 6, 2017
@Tyriar Tyriar added this to the 2.5.0 milestone Mar 6, 2017
@Tyriar Tyriar closed this Mar 8, 2017
@Tyriar Tyriar reopened this Mar 8, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-7.3%) to 60.46% when pulling 3d721a9 on AndrienkoAleksandr:cleanUpTsConfig into c9ad3a5 on sourcelair:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 60.46% when pulling 008d1df on AndrienkoAleksandr:cleanUpTsConfig into ec91a6c on sourcelair:master.

@Tyriar Tyriar merged commit ea93760 into xtermjs:master Mar 8, 2017
@Tyriar
Copy link
Member

Tyriar commented Mar 8, 2017

Thanks @AndrienkoAleksandr 😃

@AndrienkoAleksandr AndrienkoAleksandr deleted the cleanUpTsConfig branch July 17, 2017 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants