Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIXED: typo #589

Merged
merged 1 commit into from
Mar 8, 2017
Merged

FIXED: typo #589

merged 1 commit into from
Mar 8, 2017

Conversation

warpdesign
Copy link
Contributor

<div id="terminal"></div> wasn't used, instead, a new one was created and used since getElementById('#terminal') returned null.

@warpdesign
FIXED: typo
d8f8b06 
`<div id="terminal"></div>` wasn't used, instead, a new one was created and used since getElementById('#terminal') returned null.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 60.46% when pulling d8f8b06 on warpdesign:patch-1 into ea93760 on sourcelair:master.

@Tyriar
Copy link
Member

Tyriar commented Mar 8, 2017

Thanks!

@Tyriar Tyriar merged commit 2c151f4 into xtermjs:master Mar 8, 2017
@Tyriar Tyriar added this to the 2.5.0 milestone Mar 8, 2017
@Tyriar Tyriar self-assigned this Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@warpdesign @coveralls @Tyriar