Guard public selection api #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
requested changes
Jul 14, 2017
src/xterm.js
Outdated
| @@ -1437,29 +1437,33 @@ Terminal.prototype.deregisterLinkMatcher = function(matcherId) { | |||
| * Gets whether the terminal has an active selection. | |||
| */ | |||
| Terminal.prototype.hasSelection = function() { | |||
| return this.selectionManager.hasSelection; | |||
| return !!(this.selectionManager && this.selectionManager.hasSelection); | |||
There was a problem hiding this comment.
Let's simplify this so it's easier to read:
if (!this.selectionManager) {
return false;
}
return this.selectionManager.hasSelection;
Tyriar
approved these changes
Jul 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #796 by soft-failing if selection manager is not yet available (term.open not yet called). I believe this is better than throwing an error. This behaviour lines up with the behaviour of the linkifier, that only throws for sensitive api calls (like registering a link matcher for example), but otherwise soft-fails too.