Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 6 compatability fix. #46

Merged
merged 1 commit into from
Apr 2, 2016
Merged

Java 6 compatability fix. #46

merged 1 commit into from
Apr 2, 2016

Conversation

djozis
Copy link
Contributor

@djozis djozis commented Mar 21, 2016

Commit to resolve Java 6 compatability issue: #44

@djozis
Copy link
Contributor Author

djozis commented Mar 22, 2016

Perhaps this should have checked against AutoCloseable now that I think about it. Perhaps it doesn't matter.

@oehme
Copy link
Member

oehme commented Mar 22, 2016

Thank you for looking into this! :)

There are other places in the intellij plugin where we use Java 7 API (Files.copy). Extra points if you could get rid of those.

Also to make sure we actually don't use any Java 7 APIs, it would make sense to adjust the travis configuration to build on Java 6.

@djozis
Copy link
Contributor Author

djozis commented Mar 22, 2016

Unfortunately I believe you are using other Gradle plugins which target Java 7 bytecode, so using Java 6 would fail.
I've never used IntelliJ, let alone the plugin, so that may be an issue for another time, or another contributor. I may still give it a go another day.
Is it ok to treat the IntelliJ Java 6 issue separately?

@Buggaboo
Copy link

tip: use jenv to switch quickly between jdk versions.

Usage: jenv shell 1.7 or 1.6 or 1.8...

@oehme oehme merged commit 6c4080b into xtext:master Apr 2, 2016
@oehme
Copy link
Member

oehme commented Apr 2, 2016

Thank you for the fix, I will publish a patch release now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants