Lb issue 14 single release #18
Conversation
I think it's better to fail immediately instead of the end of long build
and run integration tests against the segregated local repository
looks like we save a few minutes
I think it's better to fail immediately instead of the end of long build
This way, we are sure we using our JARs in ITs.
This reverts commit 612117e.
Lb issue 16 xtext maven plugin its
This reverts commit e182d3f.
Otherwise the BOM is not GPG signed.
| <module>../org.eclipse.xtext.generator</module> | ||
| <module>../org.eclipse.xtext.java</module> | ||
| <!-- This is required by the xtext-maven-plugin IT --> | ||
| <module>../org.eclipse.xtext.purexbase</module> |
There was a problem hiding this comment.
we also publish this to maven central meanwhile
There was a problem hiding this comment.
Yes, we also publish that.
With the monorepo I think it's not needed anymore to publish that, but we can leave it like that for the moment.
Or did you mean anything else?
There was a problem hiding this comment.
am not sure about that. but i assume it does not harm to keep publishing it
There was a problem hiding this comment.
Let's say that if someone wants to experiment with the xtext-maven-plugin with an existing example Xbase-DSL they can find purexbase on Central :)
| @@ -330,6 +346,9 @@ | |||
| </properties> | |||
| <build> | |||
| <plugins> | |||
| <!-- | |||
| For the moment we do without | |||
There was a problem hiding this comment.
TODO change the urls once we move this to eclipse org
There was a problem hiding this comment.
You mean all references to the current monorepo?
I left other TODOs concerning that.
There was a problem hiding this comment.
yes the new location will be /xtext as we had discussed before. but therefore sebastian first needs to do the archive step.
| if: matrix.os == 'ubuntu-latest' | ||
| working-directory: org.eclipse.xtext.p2.releng | ||
| working-directory: org.eclipse.xtext.full.releng | ||
|
|
||
| - name: Build and test (in other OSes) | ||
| run: mvn clean verify -PuseJenkinsSnapshots |
There was a problem hiding this comment.
is the useJenkinsSnapshots profile still used?
There was a problem hiding this comment.
It's still used for this:
${JENKINS_URL}/job/lsp4j/lastStableBuild/artifact/build/maven-repository
| } | ||
|
|
||
| tools { | ||
| maven "apache-maven-3.8.6" |
There was a problem hiding this comment.
Well, I copied that part from the current Jenkinsfiles, e.g., https://github.com/eclipse/xtext-core/blob/master/Jenkinsfile#L32
should I change that with a more recent version?
There was a problem hiding this comment.
keep it for now. we can update later
| @@ -0,0 +1,56 @@ | |||
| To run the integration tests, the `target/.m2test` folder must first be populated with Maven dependencies and with the IT-SNAPSHOT jar of this Maven plugin. | |||
| @@ -280,6 +282,15 @@ private static Verifier newVerifier(String pathToTestProject) throws IOException | |||
| if (debug) { | |||
| verifier.setMavenDebug(debug); | |||
| } | |||
| String testMavenRepo = System.getProperty("testMavenRepo"); | |||
|
@cdietrich so I'm going to merge |
Closes #14