Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[utilities] secrets creation for registry.redhat.io #153

Merged
merged 1 commit into from
Sep 5, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions utilities/src/main/java/cz/xtf/XTFConfiguration.java
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ public class XTFConfiguration {
private static final String TEMPLATE_REPO = "xtf.config.template.repo";
private static final String TEMPLATE_BRANCH = "xtf.config.template.branch";

private static final String OREG_AUTH = "xtf.config.oreg.auth";
private static final String OREG_REGISTRY = "xtf.config.oreg.registry";

private static final String OPENSTACK_URL = "xtf.config.openstack.url";
private static final String OPENSTACK_TENANT = "xtf.config.openstack.tenant";
private static final String OPENSTACK_OPEN_SECURITY_GROUP = "xtf.config.openstack.security.group.open";
Expand Down Expand Up @@ -174,6 +177,14 @@ public static String routeDomain() {
return result;
}

public static String oregAuth() {
return get().readValue(OREG_AUTH);
}

public static String oregRegistry() {
return get().readValue(OREG_REGISTRY);
}

public static String proxyHost() {
return get().readValue(PROXY_HOST);
}
Expand Down Expand Up @@ -628,6 +639,12 @@ protected static Properties fromEnvironment() {
case "FUSE_DISABLE_JOLOKIA":
props.setProperty(FUSE_DISABLE_JOLOKIA, entry.getValue());
break;
case "OREG_AUTH":
props.setProperty(OREG_AUTH, entry.getValue());
break;
case "OREG_REGISTRY":
props.setProperty(OREG_REGISTRY, entry.getValue());
break;
case "OPENSTACK_URL":
props.setProperty(OPENSTACK_URL, entry.getValue());
break;
Expand Down
1 change: 1 addition & 0 deletions utilities/src/main/java/cz/xtf/build/BuildManagerV2.java
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ private BuildManagerV2() {
if (!TestConfiguration.buildNamespace().equals(TestConfiguration.masterNamespace())) {
if (master.getProject(buildNamespace) == null) {
master.createProjectRequest();
master.createORegSecret();
}

master.addRoleToGroup("system:image-puller", "system:authenticated");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import static cz.xtf.TestConfiguration.masterNamespace;
import static cz.xtf.TestConfiguration.masterPassword;
import static cz.xtf.TestConfiguration.masterUsername;

import static org.apache.commons.lang3.StringUtils.isNotBlank;

/**
Expand Down Expand Up @@ -78,6 +79,8 @@ private static void createProject(String project) {
// restore original context
openshift.setOpenShiftContext(originalContext);

OpenShiftUtils.master().createORegSecret();

log.info("action=create-project status=FINISH project={} recreate=true", project);
}

Expand Down
37 changes: 35 additions & 2 deletions utilities/src/main/java/cz/xtf/openshift/OpenShiftUtil.java
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,16 @@
import java.util.Collections;
import java.util.List;
import java.util.Map;
import java.util.Optional;
import java.util.Random;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.TimeoutException;
import java.util.concurrent.atomic.AtomicReference;
import java.util.function.BooleanSupplier;
import java.util.function.Predicate;
import java.util.stream.Collectors;

import cz.xtf.TestConfiguration;
import cz.xtf.openshift.builder.SecretBuilder;
import cz.xtf.openshift.builder.secret.SecretType;
import cz.xtf.wait.SimpleWaiter;
import cz.xtf.wait.Waiters;
import io.fabric8.kubernetes.api.model.ConfigMap;
Expand All @@ -29,6 +30,7 @@
import io.fabric8.kubernetes.api.model.HasMetadata;
import io.fabric8.kubernetes.api.model.HorizontalPodAutoscaler;
import io.fabric8.kubernetes.api.model.KubernetesList;
import io.fabric8.kubernetes.api.model.LocalObjectReference;
import io.fabric8.kubernetes.api.model.Node;
import io.fabric8.kubernetes.api.model.ObjectReference;
import io.fabric8.kubernetes.api.model.ObjectReferenceBuilder;
Expand Down Expand Up @@ -359,6 +361,37 @@ public boolean deleteSecret(Secret secret) {
return client.secrets().delete(secret);
}

/**
* Creates the secret needed for an authenticated external registry (e.g. registry.redhat.io ) and adds it to the default and builder service accounts
* Uses the TestConfiguration.oregRegistry and TestConfiguration.oregAuth properties
* @return
*/
public Secret createORegSecret() {
if (TestConfiguration.oregRegistry() != null && !TestConfiguration.oregRegistry().trim().isEmpty()) {

final String secretName = TestConfiguration.oregRegistry();

Secret oregSecret = getSecret(secretName);
if (oregSecret != null) {
deleteSecret(oregSecret);
}

Secret dockerCfg = new SecretBuilder(secretName)
.setType(SecretType.DOCKERCFG)
.addData(".dockerconfigjson", ("{\"auths\":{\"" + TestConfiguration.oregRegistry() + "\":{\"auth\":\"" + TestConfiguration.oregAuth() + "\"}}}").getBytes())
.build();
dockerCfg.getMetadata().setLabels(Collections.singletonMap(KEEP_LABEL, "keep"));
dockerCfg = createSecret(dockerCfg);

client().serviceAccounts().withName("builder").edit().addToSecrets(new ObjectReferenceBuilder().withKind("Secret").withName(secretName).build()).done();
client().serviceAccounts().withName("default").edit().addToSecrets(new ObjectReferenceBuilder().withKind("Secret").withName(secretName).build()).addToImagePullSecrets(new LocalObjectReference(secretName)).done();

return dockerCfg;
}

return null;
}

// Services
public Service createService(Service service) {
return client.services().create(service);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ public enum SecretType {

OPAQUE("Opaque"),
SERVICE_ACCOUNT("kubernetes.io/service-account-token"),
DOCKERCFG("kubernetes.io/dockercfg");
DOCKERCFG("kubernetes.io/dockerconfigjson");

private final String text;

Expand Down