Fixed used after free bug in ffi_type_array_create #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
middle::types::ffi_type_array_create
theffi_type
ofelement
is copied tonew
, but whenelement
is dropped at the end of the loop, theffi_type
is deallocated while still readable fromnew
.If we add
forget(element)
, theffi_type
won't be deallocated. SinceType::drop
only deallocates it'sffi_type
, this should be safe because theffi_type
is now owned by the resultingTypeArray
.