Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ssh functionality #2

Merged
merged 15 commits into from
May 11, 2018
Merged

Conversation

xtrasimplicity
Copy link
Owner

@xtrasimplicity xtrasimplicity commented May 2, 2018

Refactoring the SSH functionality into a wrapper around net/ssh, so that we can replace net/ssh without any major issues (if required) and simplify the core test suite and codebase.


This change is Reviewable

@xtrasimplicity xtrasimplicity changed the title Refactor ssh functionality [WIP] Refactor ssh functionality May 2, 2018
@coveralls
Copy link

coveralls commented May 2, 2018

Pull Request Test Coverage Report for Build 40

  • 189 of 229 (82.53%) changed or added relevant lines in 10 files are covered.
  • 34 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-15.6%) to 84.355%

Changes Missing Coverage Covered Lines Changed/Added Lines %
test/shared/matchers/duck_type_including.rb 12 14 85.71%
lib/shell_strike/ssh/command_result.rb 3 5 60.0%
lib/shell_strike/ssh.rb 11 47 23.4%
Files with Coverage Reduction New Missed Lines %
spec/support/helpers/chain_helpers.rb 7 41.67%
lib/shell_strike/result.rb 8 42.86%
spec/support/matchers/result.rb 19 9.52%
Totals Coverage Status
Change from base Build 32: -15.6%
Covered Lines: 399
Relevant Lines: 473

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 33

  • 85 of 110 (77.27%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-6.0%) to 94.033%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spec/shell_strike/ssh_spec.rb 67 68 98.53%
lib/shell_strike/ssh/command_result.rb 3 7 42.86%
lib/shell_strike.rb 2 6 33.33%
lib/shell_strike/ssh.rb 11 27 40.74%
Totals Coverage Status
Change from base Build 32: -6.0%
Covered Lines: 394
Relevant Lines: 419

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 33

  • 85 of 110 (77.27%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-6.0%) to 94.033%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spec/shell_strike/ssh_spec.rb 67 68 98.53%
lib/shell_strike/ssh/command_result.rb 3 7 42.86%
lib/shell_strike.rb 2 6 33.33%
lib/shell_strike/ssh.rb 11 27 40.74%
Totals Coverage Status
Change from base Build 32: -6.0%
Covered Lines: 394
Relevant Lines: 419

💛 - Coveralls

@xtrasimplicity xtrasimplicity merged commit 2682da2 into master May 11, 2018
@xtrasimplicity xtrasimplicity deleted the RefactorSSHFunctionality branch May 11, 2018 13:44
@xtrasimplicity xtrasimplicity changed the title [WIP] Refactor ssh functionality Refactor ssh functionality May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants