Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add integration tests for more containers #46

Merged
merged 2 commits into from
Sep 26, 2020
Merged

Conversation

geerteltink
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: https://www.conventionalcommits.org/
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • build: Changes that affect the build system or external dependencies
  • ci: Changes to our CI configuration files and scripts
  • docs: Documentation content changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that neither fixes a bug nor adds a feature
  • style: Changes that do not affect the meaning of the code
  • test: Adding missing tests or correcting existing tests
  • revert: Revert previous commit

What is the current behavior?

Only laminas service manager is tested.

What is the new behavior?

Add more integration tests for official laminas supported containers.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@geerteltink geerteltink added the test Adding missing tests or correcting existing tests label Sep 26, 2020
@geerteltink geerteltink added this to the 2.3.0 milestone Sep 26, 2020
@geerteltink geerteltink self-assigned this Sep 26, 2020
@geerteltink geerteltink changed the title Test/containers test: improve integration tests with different containers Sep 26, 2020
@geerteltink geerteltink changed the title test: improve integration tests with different containers test: add integration tests for more containers Sep 26, 2020
@geerteltink geerteltink merged commit 46efbb7 into 2.3.x Sep 26, 2020
@geerteltink geerteltink deleted the test/containers branch September 26, 2020 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Adding missing tests or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant