Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: PHP 8 support #52

Merged
merged 2 commits into from
Dec 15, 2020
Merged

build: PHP 8 support #52

merged 2 commits into from
Dec 15, 2020

Conversation

geerteltink
Copy link
Collaborator

@geerteltink geerteltink commented Dec 15, 2020

Enable PHP 8 support.

Not all dev dependencies are ready for PHP 8. Once they are the ignore-platform-reqs can be removed from the phpunit GitHub action.

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: https://www.conventionalcommits.org/
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • build: Changes that affect the build system or external dependencies
  • ci: Changes to our CI configuration files and scripts
  • docs: Documentation content changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that neither fixes a bug nor adds a feature
  • style: Changes that do not affect the meaning of the code
  • test: Adding missing tests or correcting existing tests
  • revert: Revert previous commit

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Not all dev dependencies are ready for PHP 8. Once they are the `ignore-platform-reqs` can be removed from the phpunit GitHub action.
@geerteltink geerteltink added the build Changes that affect the build system or external dependencies: e.g. composer, npm, yarn label Dec 15, 2020
@geerteltink geerteltink added this to the 2.4.0 milestone Dec 15, 2020
@geerteltink geerteltink self-assigned this Dec 15, 2020
@geerteltink geerteltink merged commit 7b62dc9 into 2.4.x Dec 15, 2020
@geerteltink geerteltink deleted the feat/php-8 branch December 15, 2020 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencies: e.g. composer, npm, yarn
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant