-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
when uploading dataset with pre-annotation results, tempDataId is not unique. #240
Comments
when uploading dataset with pre-annotation results, tempDataId is not generated uniquely.
The error in the test code is due to HashSet being thread-unsafe. There is no problem with generating tempDataId itself. Modifying it to |
Thank you for your comment! As you mentioned, my test code has a problem. Then what i want to make it clear is that each |
The same tempDataId can be assigned to different dataAnnotationObjectBOs, and one Data can have multiple Objects. |
oh,, i got it. i think i did misunderstand. But still i can't understand why there is something big data id in the db screenshot attached at my first comment |
The previous code had a bug. Is the large data ID in your screenshot generated by the latest version or by the previous code. |
That data id is generated by the previous code. I will check the upstream code, sorry for your wasting..time. But now, i checked, there is not that difference code, is it right? builder -> set . These changes affect to generate tempDataId? |
Yes |
okay i will update my code , and check this issue again. I really thank you for your reviewing this issue! |
Describe
when i uploaded a dataset with pre-annotation results, the process seems to work normally. However, we found that some
data_annotation_object
was missing.And I found that
UploadDataUseCase
is in charge of uploading the dataset. In particular,tempDataId
is assigned to dataAnnotationObjectBO before inserting into DB andid
which is generated after database insertion maps totempDataId
.But in this process, i found some duplicate tempDataId, and it results in mapping inappropriatly
id
totempDataId
. As a result, Uploading pre-annoation result does not work properly , ommiting some results.mapping data id to tempDataId
xtreme1/backend/src/main/java/ai/basic/x1/usecase/UploadDataUseCase.java
Line 815 in 973ee1c
mapping not properly
Cause
tempDataId is not generated uniquely in Multi - Thread.
xtreme1/backend/src/main/java/ai/basic/x1/usecase/UploadDataUseCase.java
Line 502 in 973ee1c
test code
test result
Suggest
Use synchronized blocks to "Make sure to generate tempDataId uniquely"
test code
test result
The text was updated successfully, but these errors were encountered: