Fix #177 lan server disappears after refresh #188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also logs now says attempt number
forked-from-1kasper
added a commit
to forked-from-1kasper/tigerspades
that referenced
this pull request
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also logs now says attempt number
Obviously the ping number won't be accurate but I didn't want to touch this too much let alone refactor for this small bug. Technically I guess the ping number will be only the time it took to receive the ping response? Doesn't matter it's basically for devs only anyway
Also I suppose this will generate aos ping traffic on lan every 1s, but I believe that shouldn't be an issue