Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update requirements #237

Merged
merged 3 commits into from
May 31, 2023
Merged

update requirements #237

merged 3 commits into from
May 31, 2023

Conversation

Akay7
Copy link
Contributor

@Akay7 Akay7 commented May 25, 2023

Should work just fine. There's no too much changes https://firebase.google.com/support/release-notes/admin/python

It should resolve the issue #229

@xtrinch
Copy link
Owner

xtrinch commented May 25, 2023

@Akay7 Should or does? :-) This needs at least updating the readme for the minimum supported python version as its been changed

@Akay7 Akay7 force-pushed the UpdateRequirements branch 3 times, most recently from 645773b to c3c22ec Compare May 25, 2023 12:07
@Akay7
Copy link
Contributor Author

Akay7 commented May 25, 2023

Should or does? :-)

It works, checked with https://github.com/xtrinch/fcm-django-web-demo

This needs at least updating the readme for the minimum supported python version as its been changed

I updated docs. Let me know if you would like I update it in another way.

@xtrinch
Copy link
Owner

xtrinch commented May 26, 2023

Cool, thank you! I'd like to get the current master fixed for mysql in another minor version first, then we can bump the major version and release this

@Akay7
Copy link
Contributor Author

Akay7 commented May 26, 2023

Cool, thank you! I'd like to get the current master fixed for mysql in another minor version first, then we can bump the major version and release this

Thank you very much. It could be great if you able to merge this and mysql fix into some branch ASAP.
Because I got both problems:

  1. With poetry that unable to resolve dependencies
  2. With MariaDB that unable to create too big index.

@xtrinch
Copy link
Owner

xtrinch commented May 26, 2023

@Akay7 #238 Please check it out and LMK if that fixes the MySQL problem for you sufficiently so we can get a move on this. I was unable to tag you there :-)

@Akay7
Copy link
Contributor Author

Akay7 commented May 26, 2023

Please check it out and LMK if that fixes the MySQL problem for you sufficiently so we can get a move on this. I was unable to tag you there :-)

I checked that fix, and it works for me.

@xtrinch
Copy link
Owner

xtrinch commented May 29, 2023

I will bump the major version for this due to python (in)compatibility

@xtrinch xtrinch merged commit a4ff705 into xtrinch:master May 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants