Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.sh: install latexindent perl dependencies #2

Merged
merged 4 commits into from
Nov 9, 2020
Merged

setup.sh: install latexindent perl dependencies #2

merged 4 commits into from
Nov 9, 2020

Conversation

cubercsl
Copy link
Contributor

@cubercsl cubercsl commented Nov 7, 2020

May be fix #1 but now I run these command in https://github.com/xu-cheng/texlive-action manually, but I think the setup should add in setup.sh

Appendices: https://latexindentpl.readthedocs.io/en/latest/appendices.html#lst-alpine-install

Copy link
Owner

@xu-cheng xu-cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. However, can you try to install Perl dependencies from apk to avoid unnecessary dependencies. We want to keep the image as small as possible.

setup.sh Outdated
cpanm -n File::HomeDir
cpanm -n Params::ValidationCompiler
cpanm -n YAML::Tiny
cpanm -n Unicode::GCString
Copy link
Owner

@xu-cheng xu-cheng Nov 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that you can install all these packages from apk. Please do so to avoid unnecessary dependencies.

You should be able to find the package name from https://pkgs.alpinelinux.org/packages

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems some packages like perl-file-homedir are in testing repo, so I try to add http://dl-cdn.alpinelinux.org/alpine/edge/testing in /etc/apk/repositories

head -1 /etc/apk/repositories | sed s'/alpine\/.*$/alpine\/edge\/testing/' >> /etc/apk/repositories

setup.sh Outdated
apk --no-cache add curl wget make
cd /usr/local/bin && \
curl -L https://cpanmin.us/ -o cpanm && \
chmod +x cpanm
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to introduce unnecessary dependencies. Please find if the Perl dependencies can be installed from apk directly.

setup.sh Outdated
perl-log-dispatch \
perl-namespace-autoclean \
perl-specio \
perl-unicode-linebreak
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move these to the "install system package" in the above.

@xu-cheng xu-cheng merged commit cb53251 into xu-cheng:master Nov 9, 2020
@xu-cheng
Copy link
Owner

xu-cheng commented Nov 9, 2020

Thanks @2014CAIS01.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not use latexindent in this docker image
2 participants