Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run R CMD check without warnings #1

Closed
wants to merge 28 commits into from
Closed

Conversation

rcannood
Copy link

@rcannood rcannood commented Oct 11, 2017

I've been working on allowing the R CMD check to complete without warnings.

Changelog:

  • Added a .Rbuildignore, otherwise the build check complains about various directories being included in the package
  • Added a .travis.yml file, which allows you to automatically build and check your package on travis-ci.org. Check it out! It's really cool! This is the travis page for dynverse/SLICE. It still fails on every build, because warnings generated by the build check are treated as errors in the build.
  • slice.R: added 'do.plot' arguments to several functions -- I want to be able to turn off the plotting

@rcannood rcannood changed the title Simple but necessary modifications Run R CMD check without warnings Oct 17, 2017
@rcannood
Copy link
Author

rcannood commented Oct 17, 2017

I have just pushed a few more changes. You can see on travis-ci.org that the package is now nicely able to compile without any warnings.

  • Fixed all the warnings and most of the notes that build checking produces
  • Removed all non-default packages from Depends: to Imports:, and used roxygen's @import and @importFrom notation
  • Use match.arg instead of pmatch to match arguments
  • Fixed S4 documentation
  • Added a skeleton for the demo documentation and the dataset documentation ─ better documentation definitely still needs to be added
  • Resaved the data with compression

@rcannood
Copy link
Author

Hello @xu-lab @mzguo @minzheguo,

Have you had a chance to look at this pull request yet?

Kind regards,
Robrecht

@rcannood
Copy link
Author

rcannood commented Jul 2, 2019

Closing this pull request.

@rcannood rcannood closed this Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants