Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallax Background Fix #1

Closed
xUborka opened this issue Feb 19, 2021 · 2 comments
Closed

Parallax Background Fix #1

xUborka opened this issue Feb 19, 2021 · 2 comments
Assignees
@xUborka
Labels
Background bug Something isn't working
Projects
Dash

Comments

@xUborka
Copy link
Owner

xUborka commented Feb 19, 2021 •
edited

Currently there is an issue with the parallax movement of the background layers. After some iterations a small gap appears between 2 images that should have been aligned pixel perfect
@xUborka xUborka created this issue from a note in Dash (To do) Feb 19, 2021
@xUborka xUborka added Background bug Something isn't working labels Feb 19, 2021
@xUborka
Copy link
Owner Author

xUborka commented Feb 19, 2021

image

@xUborka xUborka moved this from To do to In progress in Dash Feb 19, 2021
xUborka added a commit that referenced this issue Feb 19, 2021
@xUborka
#1 Parallax fix
3ebdb85
@xUborka xUborka moved this from In progress to Done in Dash Feb 19, 2021
@xUborka
Copy link
Owner Author

xUborka commented Feb 19, 2021 •
edited

Looks good now. I did not notice any jumps, gaps between screens, etc.
Solution : Instead of moving the images 1 by 1, I group each layer and move them together to get rid of the the accumulation of rounding errors while moving

@xUborka xUborka self-assigned this Feb 19, 2021
@xUborka xUborka closed this as completed Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xUborka xUborka

Labels
Background bug Something isn't working
Projects
Dash
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xUborka