Add support for JRuby #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, I would rather remove the version suffices... I don't see any reason to keep the suffices. What do you think? |
|
@istepura I see what you are doing here now. Could you add a jruby without versions? And also it maybe a good time to add 2.0 support for JRuby. |
|
@xuhdev I don't quite understand what you mean by "add a jruby without versions". Do you want me to add another line like or something else? |
|
@istepura Yeah. You may wanna see how Visual C++ templates work. I think this might be the best way. Also don't forget add |
|
@xuhdev I fixed (hopefully) code according to your comments |
|
Great thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.