Fix tests #29
Merged
Fix tests #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xukai92
commented
Jan 15, 2020
xukai92
commented
Jan 15, 2020
test/kliep.jl
Outdated
| @@ -1,5 +1,5 @@ | |||
| @testset "KLIEP -- $optlib" for optlib in [OptimLib, ConvexLib] | |||
| for (pair, rtol) in [(pair₁, 2e-1), (pair₂, 4e-1)] | |||
| for (i, pair, rtol) in [(1, pair₁, 2e-1), (2, pair₂, 4e-1)] | |||
There was a problem hiding this comment.
It is needed in Line 20
There was a problem hiding this comment.
Perhaps write it as enumerate([(pair1, 2e-1), (pair2, 4e-1)]) instead?
juliohm
requested changes
Jan 15, 2020
test/kliep.jl
Outdated
| @@ -1,5 +1,5 @@ | |||
| @testset "KLIEP -- $optlib" for optlib in [OptimLib, ConvexLib] | |||
| for (pair, rtol) in [(pair₁, 2e-1), (pair₂, 4e-1)] | |||
| for (i, pair, rtol) in [(1, pair₁, 2e-1), (2, pair₂, 4e-1)] | |||
There was a problem hiding this comment.
Perhaps write it as enumerate([(pair1, 2e-1), (pair2, 4e-1)]) instead?
test/kmm.jl
Outdated
| @@ -1,22 +1,21 @@ | |||
| @testset "KMM -- $optlib" for optlib in [JuliaLib, JuMPLib] | |||
| for (i, pair) in enumerate([pair₁, pair₂]) | |||
| for (i, pair, rtol) in [(1, pair₁, 2e-1), (2, pair₂, 4e-1)] | |||
There was a problem hiding this comment.
I think we can keep enumarate here like suggested above.
|
I will address them during weekends. |
|
Okay so I replaced explicit indexing with |
juliohm
approved these changes
Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KMM test is now fixed. There was also a bug in the KLIEP test (missing
ifor creating the names of plots)