Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ use template from local #51

Merged
merged 5 commits into from
Mar 18, 2024

Conversation

haoyanwang
Copy link
Contributor

@haoyanwang haoyanwang commented Mar 18, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?
new feature that support dev params to use loca tgz

[ ] Bugfix
[✅] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

What is the new behavior?

support dev params to use loca tgz

Does this PR introduce a breaking change?

[ ] Yes
[✅] No

Other information

@haoyanwang haoyanwang changed the base branch from main to release/1.1 March 18, 2024 04:39
@uaenaTzx
Copy link
Collaborator

首先 pr 提交的说明不用给 ✅,下面这几个提交后可以手动勾选的
-[] The commit message follows our guidelines: https://github.com/xun082/create-neat/blob/master/CONTRIBUTING.md
-[] Tests for the changes have been added (for bug fixes / features)
-[] Docs have been added / updated (for bug fixes / features)

Copy link
Collaborator

@uaenaTzx uaenaTzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

逻辑实现没有大问题,一些细节现在也不用去规范,因为考虑到后面重构,会对一些核心逻辑之外的配置做调整。

@uaenaTzx
Copy link
Collaborator

@xun082 你再过一下看看

@xun082 xun082 merged commit ef26a42 into xun082:release/1.1 Mar 18, 2024
1 check passed
@haoyanwang
Copy link
Contributor Author

首先 pr 提交的说明不用给 ✅,下面这几个提交后可以手动勾选的 -[] The commit message follows our guidelines: https://github.com/xun082/create-neat/blob/master/CONTRIBUTING.md -[] Tests for the changes have been added (for bug fixes / features) -[] Docs have been added / updated (for bug fixes / features)

👌

xun082 added a commit that referenced this pull request Mar 18, 2024
* ci: 🎡 add a new workflow (#25)

* ci: 🎡 add a new workflow

* ci: 🎡 add a new workflow

* ci: 🎡 add a new workflow

* ci: 🎡 add a new workflow

* feat: 修改本地 lint-stage 流程 (#38)

* docs: add CONTRIBUTING documents in both Chinese and Englist

* docs: add CONTRIBUTING documents in both Chinese and Englist

* docs: add CONTRIBUTING documents in both Chinese and Englist(#35)

* docs: add CONTRIBUTING documents in both Chinese and Englist(#35)

* feat: ✨ use template from local (#51)

* feat: ✨ use template from local

* bug: 🐛 add fallback

* label: 🏷️ fix type

* bug: 🔥 remove code

* feat: 🚨 fix prettier error #27

* fix: 🧩 修复 ci 配置文件错误导致的 ci 失败 (#59)

---------

Co-authored-by: Moment <73689580+xun082@users.noreply.github.com>
Co-authored-by: KoEkko <114348497+KoEkko@users.noreply.github.com>
Co-authored-by: 王皓衍 <44564817+haoyanwang@users.noreply.github.com>
@xun082 xun082 added the enhancement New feature or request label Mar 19, 2024
@haoyanwang haoyanwang deleted the feat-local-template#27 branch April 2, 2024 03:41
uaenaTzx added a commit that referenced this pull request Jun 29, 2024
* ci: 🎡 add a new workflow (#25)

* feat: 修改本地 lint-stage 流程 (#38)

* docs: add CONTRIBUTING documents in both Chinese and Englist(#35)

* feat: ✨ use template from local (#51)

* bug: 🐛 add fallback

* label: 🏷️ fix type

* bug: 🔥 remove code

* feat: 🚨 fix prettier error #27

* fix: 🧩 修复 ci 配置文件错误导致的 ci 失败 (#59)

---------

Co-authored-by: Moment <73689580+xun082@users.noreply.github.com>
Co-authored-by: KoEkko <114348497+KoEkko@users.noreply.github.com>
Co-authored-by: 王皓衍 <44564817+haoyanwang@users.noreply.github.com>
yhstsy pushed a commit to yhstsy/create-neat that referenced this pull request Jul 9, 2024
* ci: 🎡 add a new workflow (xun082#25)

* ci: 🎡 add a new workflow

* ci: 🎡 add a new workflow

* ci: 🎡 add a new workflow

* ci: 🎡 add a new workflow

* feat: 修改本地 lint-stage 流程 (xun082#38)

* docs: add CONTRIBUTING documents in both Chinese and Englist

* docs: add CONTRIBUTING documents in both Chinese and Englist

* docs: add CONTRIBUTING documents in both Chinese and Englist(xun082#35)

* docs: add CONTRIBUTING documents in both Chinese and Englist(xun082#35)

* feat: ✨ use template from local (xun082#51)

* feat: ✨ use template from local

* bug: 🐛 add fallback

* label: 🏷️ fix type

* bug: 🔥 remove code

* feat: 🚨 fix prettier error xun082#27

* fix: 🧩 修复 ci 配置文件错误导致的 ci 失败 (xun082#59)

---------

Co-authored-by: Moment <73689580+xun082@users.noreply.github.com>
Co-authored-by: KoEkko <114348497+KoEkko@users.noreply.github.com>
Co-authored-by: 王皓衍 <44564817+haoyanwang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

实现本地模板直接引用(不必有所改动就发一次版)
3 participants