Use on/off for stop on fail banner display

xunit · Nov 12, 2023 · 4e99b52 · 4e99b52
1 parent 64d2a15
commit 4e99b52
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 6 deletions.
diff --git a/src/xunit.runner.utility/Reporters/DefaultRunnerReporterMessageHandler.cs b/src/xunit.runner.utility/Reporters/DefaultRunnerReporterMessageHandler.cs
@@ -230,14 +230,13 @@ protected override bool Visit(ITestAssemblyExecutionStarting executionStarting)
             if (executionStarting.ExecutionOptions.GetDiagnosticMessagesOrDefault())
             {
                 var threadCount = executionStarting.ExecutionOptions.GetMaxParallelThreadsOrDefault();
-                var stopOnFail = executionStarting.ExecutionOptions.GetStopOnTestFailOrDefault().ToString().ToLowerInvariant();
 
                 Logger.LogImportantMessage(
                     "  Starting:    {0} (parallel test collections = {1}, max threads = {2}, stop on fail = {3})",
                     assemblyDisplayName,
                     !executionStarting.ExecutionOptions.GetDisableParallelizationOrDefault() ? "on" : "off",
                     threadCount < 0 ? "unlimited" : threadCount.ToString(CultureInfo.CurrentCulture),
-                    stopOnFail
+                    executionStarting.ExecutionOptions.GetStopOnTestFailOrDefault() ? "on" : "off"
                 );
             }
             else

diff --git a/src/xunit.runner.utility/Reporters/DefaultRunnerReporterWithTypesMessageHandler.cs b/src/xunit.runner.utility/Reporters/DefaultRunnerReporterWithTypesMessageHandler.cs
@@ -252,14 +252,13 @@ protected virtual void HandleTestAssemblyExecutionStarting(MessageHandlerArgs<IT
             if (executionStarting.ExecutionOptions.GetDiagnosticMessagesOrDefault())
             {
                 var threadCount = executionStarting.ExecutionOptions.GetMaxParallelThreadsOrDefault();
-                var stopOnFail = executionStarting.ExecutionOptions.GetStopOnTestFailOrDefault().ToString().ToLowerInvariant();
 
                 Logger.LogImportantMessage(
                     "  Starting:    {0} (parallel test collections = {1}, max threads = {2}, stop on fail = {3})",
                     assemblyDisplayName,
                     !executionStarting.ExecutionOptions.GetDisableParallelizationOrDefault() ? "on" : "off",
                     threadCount < 0 ? "unlimited" : threadCount.ToString(CultureInfo.CurrentCulture),
-                    stopOnFail
+                    executionStarting.ExecutionOptions.GetStopOnTestFailOrDefault() ? "on" : "off"
                 );
             }
             else

diff --git a/test/test.xunit.runner.utility/Extensibility/DefaultRunnerReporterMessageHandlerTests.cs b/test/test.xunit.runner.utility/Extensibility/DefaultRunnerReporterMessageHandlerTests.cs
@@ -151,7 +151,7 @@ public class OnMessage_ITestAssemblyExecutionStarting
     {
         [Theory]
         [InlineData(false, "[Imp] =>   Starting:    testAssembly")]
-        [InlineData(true, "[Imp] =>   Starting:    testAssembly (parallel test collections = on, max threads = 42, stop on fail = true)")]
+        [InlineData(true, "[Imp] =>   Starting:    testAssembly (parallel test collections = on, max threads = 42, stop on fail = on)")]
         public static void LogsMessage(bool diagnosticMessages, string expectedResult)
         {
             var message = Mocks.TestAssemblyExecutionStarting(diagnosticMessages: diagnosticMessages);

diff --git a/...t.xunit.runner.utility/Extensibility/DefaultRunnerReporterWithTypesMessageHandlerTests.cs b/...t.xunit.runner.utility/Extensibility/DefaultRunnerReporterWithTypesMessageHandlerTests.cs
@@ -149,7 +149,7 @@ public class OnMessage_ITestAssemblyExecutionStarting
     {
         [Theory]
         [InlineData(false, "[Imp] =>   Starting:    testAssembly")]
-        [InlineData(true, "[Imp] =>   Starting:    testAssembly (parallel test collections = on, max threads = 42, stop on fail = true)")]
+        [InlineData(true, "[Imp] =>   Starting:    testAssembly (parallel test collections = on, max threads = 42, stop on fail = on)")]
         public static void LogsMessage(bool diagnosticMessages, string expectedResult)
         {
             var message = Mocks.TestAssemblyExecutionStarting(diagnosticMessages: diagnosticMessages);