#2755: Tests for another embedded collection regression (v2)

xunit · Sep 22, 2023 · 9ab4ece · 9ab4ece
1 parent e499f14
commit 9ab4ece
Show file tree

Hide file tree

Showing 2 changed files with 149 additions and 1 deletion.
diff --git a/src/xunit.assert/Asserts b/src/xunit.assert/Asserts
diff --git a/test/test.xunit.assert/Asserts/CollectionAssertsTests.cs b/test/test.xunit.assert/Asserts/CollectionAssertsTests.cs
@@ -1152,6 +1152,80 @@ public static void WithCollectionValues_NotEqual()
 					ex.Message
 				);
 			}
+
+			[Fact]
+			public void ComplexEmbeddedValues_Equal()
+			{
+				var expected = new Dictionary<string, object>()
+				{
+					["key"] = new Dictionary<string, object>()
+					{
+						["key"] = new List<Dictionary<string, object>>()
+						{
+							new Dictionary<string, object>()
+							{
+								["key"] = new List<object> { "value" }
+							}
+						}
+					}
+				};
+				var actual = new Dictionary<string, object>()
+				{
+					["key"] = new Dictionary<string, object>()
+					{
+						["key"] = new List<Dictionary<string, object>>()
+						{
+							new Dictionary<string, object>()
+							{
+								["key"] = new List<object> { "value" }
+							}
+						}
+					}
+				};
+
+				Assert.Equal(expected, actual);
+			}
+
+			[Fact]
+			public void ComplexEmbeddedValues_NotEqual()
+			{
+				var expected = new Dictionary<string, object>()
+				{
+					["key"] = new Dictionary<string, object>()
+					{
+						["key"] = new List<Dictionary<string, object>>()
+						{
+							new Dictionary<string, object>()
+							{
+								["key"] = new List<object> { "value1" }
+							}
+						}
+					}
+				};
+				var actual = new Dictionary<string, object>()
+				{
+					["key"] = new Dictionary<string, object>()
+					{
+						["key"] = new List<Dictionary<string, object>>()
+						{
+							new Dictionary<string, object>()
+							{
+								["key"] = new List<object> { "value2" }
+							}
+						}
+					}
+				};
+
+				var ex = Record.Exception(() => Assert.Equal(expected, actual));
+
+				Assert.IsType<EqualException>(ex);
+				Assert.Equal(
+					"Assert.Equal() Failure: Dictionaries differ" + Environment.NewLine +
+					"Expected: [[\"key\"] = [[\"key\"] = [[[\"key\"] = [\"value1\"]]]]]" + Environment.NewLine +
+					"Actual:   [[\"key\"] = [[\"key\"] = [[[\"key\"] = [\"value2\"]]]]]",
+					ex.Message
+				);
+			}
 		}
 
 		public class Sets
@@ -1607,6 +1681,80 @@ public static void WithCollectionValues_NotEqual()
 
 				Assert.NotEqual(expected, actual);
 			}
+
+			[Fact]
+			public void ComplexEmbeddedValues_Equal()
+			{
+				var expected = new Dictionary<string, object>()
+				{
+					["key"] = new Dictionary<string, object>()
+					{
+						["key"] = new List<Dictionary<string, object>>()
+						{
+							new Dictionary<string, object>()
+							{
+								["key"] = new List<object> { "value" }
+							}
+						}
+					}
+				};
+				var actual = new Dictionary<string, object>()
+				{
+					["key"] = new Dictionary<string, object>()
+					{
+						["key"] = new List<Dictionary<string, object>>()
+						{
+							new Dictionary<string, object>()
+							{
+								["key"] = new List<object> { "value" }
+							}
+						}
+					}
+				};
+
+				var ex = Record.Exception(() => Assert.NotEqual(expected, actual));
+
+				Assert.IsType<NotEqualException>(ex);
+				Assert.Equal(
+					"Assert.NotEqual() Failure: Dictionaries are equal" + Environment.NewLine +
+					"Expected: Not [[\"key\"] = [[\"key\"] = [[[\"key\"] = [\"value\"]]]]]" + Environment.NewLine +
+					"Actual:       [[\"key\"] = [[\"key\"] = [[[\"key\"] = [\"value\"]]]]]",
+					ex.Message
+				);
+			}
+
+			[Fact]
+			public void ComplexEmbeddedValues_NotEqual()
+			{
+				var expected = new Dictionary<string, object>()
+				{
+					["key"] = new Dictionary<string, object>()
+					{
+						["key"] = new List<Dictionary<string, object>>()
+						{
+							new Dictionary<string, object>()
+							{
+								["key"] = new List<object> { "value1" }
+							}
+						}
+					}
+				};
+				var actual = new Dictionary<string, object>()
+				{
+					["key"] = new Dictionary<string, object>()
+					{
+						["key"] = new List<Dictionary<string, object>>()
+						{
+							new Dictionary<string, object>()
+							{
+								["key"] = new List<object> { "value2" }
+							}
+						}
+					}
+				};
+
+				Assert.NotEqual(expected, actual);
+			}
 		}
 
 		public class Sets