Ensure all throws of NotImplementedException contain messages

xunit · Oct 26, 2023 · e139d77 · e139d77
1 parent 8a84fdb
commit e139d77
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/xunit.core/Record.cs b/src/xunit.core/Record.cs
@@ -60,7 +60,7 @@ public static Exception Exception(Func<object> testCode)
         /// <summary/>
         [EditorBrowsable(EditorBrowsableState.Never)]
         [Obsolete("You must call Record.ExceptionAsync (and await the result) when testing async code.", true)]
-        public static Exception Exception(Func<Task> testCode) { throw new NotImplementedException(); }
+        public static Exception Exception(Func<Task> testCode) { throw new NotImplementedException("You must call Record.ExceptionAsync (and await the result) when testing async code."); }
 
         /// <summary>
         /// Records any exception which is thrown by the given task.

diff --git a/src/xunit.runner.utility/Frameworks/v1/Xunit1ReflectionWrapper.cs b/src/xunit.runner.utility/Frameworks/v1/Xunit1ReflectionWrapper.cs
@@ -133,7 +133,7 @@ IEnumerable<IParameterInfo> IMethodInfo.GetParameters()
 
         IMethodInfo IMethodInfo.MakeGenericMethod(params ITypeInfo[] typeArguments)
         {
-            throw new NotImplementedException();
+            throw new NotImplementedException("This API is new for v2 and should never be called for v1");
         }
 
         // ITypeInfo