#2913: Assert.Equivalent behaves incorrectly with decimal values (v2)

xunit · Apr 9, 2024 · e3c980f · e3c980f
1 parent 57af1d9
commit e3c980f
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 1 deletion.
diff --git a/src/xunit.assert/Asserts b/src/xunit.assert/Asserts
diff --git a/test/test.xunit.assert/Asserts/EquivalenceAssertsTests.cs b/test/test.xunit.assert/Asserts/EquivalenceAssertsTests.cs
@@ -74,6 +74,43 @@ public void SameValueFromDifferentIntrinsicTypes_Success()
 		{
 			Assert.Equivalent(12, 12L);
 		}
+
+		// https://github.com/xunit/xunit/issues/2913
+		[Fact]
+		public void Decimals_Success()
+		{
+			Assert.Equivalent(1m, 1m);
+		}
+
+		// https://github.com/xunit/xunit/issues/2913
+		[Fact]
+		public void Decimals_Failure()
+		{
+			var ex = Record.Exception(() => Assert.Equivalent(1m, 2m));
+
+			Assert.IsType<EquivalentException>(ex);
+			Assert.Equal(
+				"Assert.Equivalent() Failure" + Environment.NewLine +
+				"Expected: 1" + Environment.NewLine +
+				"Actual:   2",
+				ex.Message
+			);
+		}
+
+		// https://github.com/xunit/xunit/issues/2913
+		[Fact]
+		public void IntrinsicPlusNonIntrinsic_Failure()
+		{
+			var ex = Record.Exception(() => Assert.Equivalent(1m, new object()));
+
+			Assert.IsType<EquivalentException>(ex);
+			Assert.Equal(
+				"Assert.Equivalent() Failure" + Environment.NewLine +
+				"Expected: 1" + Environment.NewLine +
+				"Actual:   Object { }",
+				ex.Message
+			);
+		}
 	}
 
 	public class NullableValueTypes