#2682: Apply assembly-wide ExcludeFromCodeCoverageAttribute (v2)

xunit · May 15, 2023 · eba74cf · eba74cf
1 parent cd43469
commit eba74cf
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Directory.Build.props b/src/Directory.Build.props
@@ -15,7 +15,7 @@
     <GenerateAssemblyTitleAttribute>false</GenerateAssemblyTitleAttribute>
     <GenerateAssemblyVersionAttribute>false</GenerateAssemblyVersionAttribute>
     <LangVersion>10.0</LangVersion>
-    <NoWarn>$(NoWarn);NU1603;NU5128;NU5131;CS1701</NoWarn>
+    <NoWarn>$(NoWarn);NU1603;NU5128;NU5131;CS0436;CS1701</NoWarn>
     <PackageId>$(MSBuildProjectName)</PackageId>
     <RootNamespace>Xunit</RootNamespace>
     <SignAssembly>true</SignAssembly>

diff --git a/src/common/GlobalAssemblyInfo.cs b/src/common/GlobalAssemblyInfo.cs
@@ -1,13 +1,13 @@
-using System.Reflection;
+using System.Diagnostics.CodeAnalysis;
+using System.Reflection;
 
 [assembly: AssemblyCompany(".NET Foundation")]
 [assembly: AssemblyProduct("xUnit.net Testing Framework")]
 [assembly: AssemblyCopyright("Copyright (C) .NET Foundation")]
+[assembly: ExcludeFromCodeCoverage]
 
-#if NET35 || NETCOREAPP1_0
 namespace System.Diagnostics.CodeAnalysis
 {
     [AttributeUsage(AttributeTargets.Assembly | AttributeTargets.Class | AttributeTargets.Constructor | AttributeTargets.Event | AttributeTargets.Method | AttributeTargets.Property | AttributeTargets.Struct, AllowMultiple = false, Inherited = false)]
     internal sealed class ExcludeFromCodeCoverageAttribute : Attribute { }
 }
-#endif