Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionality to honor CollectSourceInformation flag from RunSettings XML #1352

Merged
merged 2 commits into from
Jul 10, 2017

Conversation

Shyam-Gupta
Copy link
Contributor

Refer RFC: https://github.com/Microsoft/vstest-docs/blob/master/RFCs/0010-Source-Information-For-Discovered-Tests.md

Summary:
CollectSourceInformation = True => Test adapter needs to collect source information for the discovered tests
CollectSourceInformation = False => Test adapter doesn't need to collect source information for discovered tests. In case tests are executed from VS IDE, then Test Window will get this information using Roslyn.

By default CollectSourceInformation will be true. It will be false when:

  1. VS IDE determines that it can get this information from Roslyn
  2. Command line scenario: When tests are executed from vstest.console.exe, this flag will always be false unless user explicitly overrides it in the runsettings XML file.

@dnfclas
Copy link

dnfclas commented Jul 6, 2017

@Shyam-Gupta,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@clairernovotny
Copy link
Member

Why was ReporterSwitch removed?

@Shyam-Gupta
Copy link
Contributor Author

@onovotny
ReporterSwitch was already in commented out state. Its only indentation changes which came in automatically by VS.

@bradwilson
Copy link
Member

I cleaned up the RunSettingsHelper class, including enabling ReporterSwitch (understanding that nobody's listening to it yet, but that shouldn't matter).

@bradwilson bradwilson merged commit 016cff7 into xunit:master Jul 10, 2017
@bradwilson
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants