Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh the state between observer runs #23

Merged
merged 2 commits into from Nov 5, 2023
Merged

Conversation

someonewithpc
Copy link
Contributor

This fixes a case where observer B depends on A and sets it's state from it, and C depends on B and attempts to set it's state from it. Previously, the C did not get the updated state, after the B set action was handled, whereas now each observer gets the most recent state.

@someonewithpc
Copy link
Contributor Author

@xuoe Could you take a look at this?

someonewithpc added a commit to someonewithpc/redux-observers that referenced this pull request Aug 9, 2023
@xuoe
Copy link
Owner

xuoe commented Nov 4, 2023

Thanks for the PR, and apologies for the late reply.

Could you please drop all other commits except 71a818f and a05512b and force-push? I'll recreate them in a new commit and also bump the major version, since this is a breaking change.

@someonewithpc
Copy link
Contributor Author

@xuoe Done

@xuoe xuoe merged commit bcdd384 into xuoe:master Nov 5, 2023
@xuoe
Copy link
Owner

xuoe commented Nov 5, 2023

Thanks, @someonewithpc! Will publish today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants