Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InsecureRequestWarning when fetching feeds #10

Closed
philgyford opened this issue Oct 5, 2022 · 2 comments
Closed

InsecureRequestWarning when fetching feeds #10

philgyford opened this issue Oct 5, 2022 · 2 comments

Comments

@philgyford
Copy link
Contributor

With every feed I fetch I get this warning:

/usr/local/lib/python3.10/site-packages/urllib3/connectionpool.py:1045: InsecureRequestWarning:
Unverified HTTPS request is being made to host 'www.example.com'.
Adding certificate verification is strongly advised.
See: https://urllib3.readthedocs.io/en/1.26.x/advanced-usage.html#ssl-warnings

I think this is because in this line in utils.read_feed():

ret = requests.get(feed_url, headers=headers, verify=False, allow_redirects=False, timeout=20, proxies=proxies)

there's verify=False. Given the default is True, I'm wondering why it's set to False, which generates these warnings?

@xurble
Copy link
Owner

xurble commented Nov 4, 2022

It's because on my original hosting, many moons ago, I couldn't install client certificates to make verified requests work.

It's probably not necessary now.

xurble added a commit that referenced this issue Feb 24, 2024
…ng-feeds

Fixes Issue #10 InsecureRequestWarning when fetching feeds
@xurble
Copy link
Owner

xurble commented Feb 24, 2024

Fixed in next release.

@xurble xurble closed this as completed Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants