Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: [HUDI-3730] add global tools UT #13

Conversation

fengjian428
Copy link

Tips

What is the purpose of the pull request

(For example: This pull request adds quick-start document.)

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@fengjian428 fengjian428 changed the title [HUDI-3730] add global tools UT Draft: [HUDI-3730] add global tools UT Jun 26, 2022
@xushiyan xushiyan merged commit 1d52511 into xushiyan:HUDI-3730-metasyncrefactoring Jun 26, 2022
xushiyan pushed a commit that referenced this pull request Jun 30, 2022
Co-authored-by: jian.feng <jian.feng@shopee.com>
xushiyan pushed a commit that referenced this pull request Jul 3, 2022
Co-authored-by: jian.feng <jian.feng@shopee.com>
@fengjian428 fengjian428 deleted the HUDI-3730-AddUTs2GlobalCommitTool branch December 29, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants