Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitcopy doesn't work with capistrano-rvm #22

Closed
kbeckman opened this issue May 20, 2015 · 5 comments
Closed

gitcopy doesn't work with capistrano-rvm #22

kbeckman opened this issue May 20, 2015 · 5 comments

Comments

@kbeckman
Copy link
Contributor

This line of code is the issue...

Since this gem is using capture instead of execute :ruby, '--args' capistrano-rvm cannot plug in the rvm:hook task for this command. I spent a lot of time troubleshooting this one and took a lot of wrong turns trying to get Cap3 to work with a login shell, trying to rewrite the gitcopy:deploy task to include the rvm:hook among others... Once I finally figured out how capistrano-rvm was injecting the call to RVM the solution was an easy one.

If you have any questions, please let me know... I'll be submitting a pull request shortly.

@kbeckman
Copy link
Contributor Author

PR submitted... Thanks, @xuwupeng2000.

@Daniel-ltw
Copy link
Collaborator

One question I have regarding this rvm:hook is, if a user is not using RVM, would your changes still work for them?

@kbeckman
Copy link
Contributor Author

It will... It simply replaces the capture call with execute :ruby, '--arguments'. If users aren't using capistrano-rvm it will simply work as normal. However, since the line now uses execute :ruby, capistrano-rvm can inject a wrapper around that call to use RVM if necessary.

@xuwupeng2000
Copy link
Owner

Awesome !
Thank you

@kbeckman
Copy link
Contributor Author

Thanks for merging that in so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants