Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Aggregate the JS and CSS files (we own) that are loaded on every page.
- Loading branch information
Showing
4 changed files
with
44 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a679063
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. This looks important and it will affect the user, I'd have created a jira issue for it.
a679063
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for an issue and mention in the release notes, it's kind of a backwards compatibility breakage.
a679063
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sergiu, can you explain how it can break backwards compatibility? Note that all the aggregated files are still in the war so any extension that was using those files separately should continue to work. Do you have in mind the case when a JavaScript code is loaded (and executed) twice, once from the aggregated file and once separately?
a679063
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a functional backwards compatibility, since by default everything works, but it breaks builds that override such files in a "downstream" distribution (i.e. unzip the XE war, change a file with a patched version, re-zip a new war).
a679063
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand, thanks.