XWiki 7941 : PR leak when displaying TextArea properties #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code style is not consistent, especially the indentation of comments. Make sure you use XWiki's code style. |
|
Sorry for that. There was some tab characters in my IDE, so it was rendering nicely in it, but not on github ! Should be fixed now :) Thanks. |
| context.remove(XWikiConstant.DROPPED_PERMISSIONS); | ||
| } | ||
| } catch (XWikiException e) { | ||
| LOGGER.warn("Failed to check rights for this textArea : " + e.toString()); |
There was a problem hiding this comment.
thomas, I'd have put this in a separate method to make the code a bit cleaner/structured.
Also the restoration of the dropped PR should be done in a finally block IMO.
There was a problem hiding this comment.
My bad, this PR was closed as it was done by Marius already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.