Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWiki-8594 : XSS in Main.SpaceIndex on space name #121

Merged
merged 2 commits into from Jun 17, 2013

Conversation

tdelafosse
Copy link
Contributor

No description provided.

@mflorea
Copy link
Member

mflorea commented Jun 17, 2013

Perfect. Now, I'm wondering if we should handle the case when row["${jscolname}"] is null. I know it's an edge case, but considering that Prototype's Element#update() is null-safe it means that some JSON response that worked before (if it worked? even if it's a bad/incomplete response) will break the live table now. Something like:

(row["${jscolname}"] || '').escapeHTML()

could preserve the null-safe behaviour.

@tdelafosse
Copy link
Contributor Author

Yes I didn't think about that one. Thanks for having seen that :). Fixed.

mflorea added a commit that referenced this pull request Jun 17, 2013
XWiki-8594 : XSS in Main.SpaceIndex on space name
@mflorea mflorea merged commit 88263bd into xwiki:master Jun 17, 2013
@mflorea
Copy link
Member

mflorea commented Jun 17, 2013

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants