New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XWiki 9151 : XSS vulnerability in link syntax when using "path:" #122
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f85dc55
XWiki-9151 : XSS vulnerability in link syntax when using "path:"
tdelafosse 62e5f4e
XWiki-9151 : XSS vulnerability in link syntax when using "path:". Add…
tdelafosse 2824370
XWiki-9151 : XSS vulnerability in link syntax when using "path:". Add…
tdelafosse 9e2be48
XWiki-9151 : XSS vulnerability in link syntax when using "path:". Cle…
tdelafosse cd1d707
XSS vulnerability in link syntax when using "path:". Add extraAttribu…
tdelafosse 7d2c3f4
XSS vulnerability in link syntax when using "path:". Use a secure ren…
tdelafosse File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,7 @@ | |
*/ | ||
package org.xwiki.rendering.internal.configuration; | ||
|
||
import java.util.ArrayList; | ||
import java.util.Arrays; | ||
import java.util.List; | ||
import java.util.Properties; | ||
|
@@ -98,4 +99,10 @@ public List<String> getTransformationNames() | |
{ | ||
return this.configuration.getProperty(PREFIX + "transformations", Arrays.asList("macro", "icon")); | ||
} | ||
|
||
@Override | ||
public List<String> getExtraAttributes() | ||
{ | ||
return this.configuration.getProperty(PREFIX + "extraAttributes", new ArrayList<String>()); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I can replace it with a method to add extra regex instead of attributes if needed. |
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because I transformed XHTMLWikiPrinter into an interface implemented by DefaultXHTMLWikiPrinter