Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-21253: Improve the Gradient of buttons #2316

Merged
merged 1 commit into from Sep 4, 2023

Conversation

manuelleduc
Copy link
Contributor

@manuelleduc manuelleduc commented Aug 29, 2023

Jira: https://jira.xwiki.org/browse/XWIKI-21253
Forum discussion: https://forum.xwiki.org/t/gradient-on-buttons-minimalist-skin-design-1/12618/
Follow up work on image borders: #2319

Draft PR

I will document below some before/after screenshot of some elements of XWiki Standard with and without gradients on buttons.

Comment button

Base

before

image

after

image

Hover

before

image

after

image

Active

before

image

after

image

Disabled

image

after

image

Edit page buttons

The state change are on Save & View.

Base

before

image

after

image

Hover

before

image

after

image

Active

before

image

after

image

Disabled

image

after

image

@Sereza7
Copy link
Contributor

Sereza7 commented Aug 30, 2023

Looks good to me 👍

Do you think we could remove the .btn-gradient(@color) mixin? I couldn't find any other occurence of it used in the xwiki organisation on github and I don't think it would make much sense for an extension or a custom script to use it because we already have 5 button variations that should be used instead of implementing a whole new button type.

EDIT: fixed a mistype .btn-background(@color) --> .btn-gradient(@color)

@manuelleduc
Copy link
Contributor Author

Do you think we could remove the .btn-gradient(@color) mixin? I couldn't find any other occurence of it used in the xwiki organisation on github and I don't think it would make much sense for an extension or a custom script to use it because we already have 5 button variations that should be used instead of implementing a whole new button type.

I've considered it and:

  1. it's been there since so long I would say it's part of the API (but we could agree to break it)
  2. this can still be useful for whoever creates a theme with gradient buttons on top of flamingo

@manuelleduc manuelleduc marked this pull request as ready for review August 30, 2023 12:06
@manuelleduc manuelleduc merged commit 9be2ea2 into xwiki:master Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants