Break notification filter provider #2882
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surli
force-pushed
the
break-notification-filter-provider
branch
from
ea68bae
to
7fd885e
Compare
…enceProvider WIP: Experimental removal of NotificationFilterPreferenceProvider.
surli
force-pushed
the
break-notification-filter-provider
branch
from
7fd885e
to
07020d9
Compare
surli
commented
Feb 13, 2024
| @@ -297,8 +295,7 @@ private boolean isEnabledScopeNotificationFilterPreference(NotificationFilterPre | |||
| { | |||
| // This optimization can only works on preferences stored by the user, that's why we add a condition | |||
| // on the provider hint. | |||
| return nfp.isEnabled() && ScopeNotificationFilter.FILTER_NAME.equals(nfp.getFilterName()) | |||
| && UserProfileNotificationFilterPreferenceProvider.HINT.equals(nfp.getProviderHint()); | |||
| return nfp.isEnabled() && ScopeNotificationFilter.FILTER_NAME.equals(nfp.getFilterName()); | |||
There was a problem hiding this comment.
Hmmm I just realized that this method was having the following documentation:
NOTE: this work only with user's preferences stocked in the database. It does not support the use-case of
* the notifications macro, when the preferences are created on the fly based on the macro parameters!
I probably need to check it a bit more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
TBD
Changes
Description
Experimental removal of NotificationFilterPreferenceProvider.
Clarifications
Executed Tests
TBD
Expected merging strategy