Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XWIKI-21878: Various close button modals do not use intended icons #2888

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

XWIKI-21878: Various close button modals do not use intended icons #2888

wants to merge 10 commits into from

Commits on Feb 14, 2024

  1. XWIKI-21878: Various close button modals do not use intended icons 

    * Removed the hard coded values from the templates.
* Made a REST API call from modal.js to access the current icontheme icon.

Note: The only occurrence of `×` left in the project is the fallback value for the modal.js template.
    @Sereza7
    Sereza7 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    883e07d View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Merge branch 'xwiki:master' into XWIKI-21878

    @Sereza7
    Sereza7 committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    6af9611 View commit details
    Browse the repository at this point in the history

  2. XWIKI-21878: Various close button modals do not use intended icons 

    * Tried to change modal API call syntax
    @Sereza7
    Sereza7 committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    b95e57d View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Merge branch 'xwiki:master' into XWIKI-21878

    @Sereza7
    Sereza7 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    0bfc237 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Merge branch 'xwiki:master' into XWIKI-21878

    @Sereza7
    Sereza7 committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    505952d View commit details
    Browse the repository at this point in the history

  2. XWIKI-21878: Various close button modals do not use intended icons 

    * <WIP fixing the async call to API>
    @Sereza7
    Sereza7 committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    b1e19f5 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. XWIKI-21878: Various close button modals do not use intended icons 

    * Finished changing the library used to call the REST API
    @Sereza7
    Sereza7 committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    f6c9424 View commit details
    Browse the repository at this point in the history

  2. XWIKI-21878: Various close button modals do not use intended icons 

    * Improved codestyle
    @Sereza7
    Sereza7 committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    44e650d View commit details
    Browse the repository at this point in the history

  3. XWIKI-21878: Various close button modals do not use intended icons 

    * URIEncoded current wiki names
    @Sereza7
    Sereza7 committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    217df8a View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Merge branch 'master' into XWIKI-21878

    @Sereza7
    Sereza7 committed May 16, 2024
    Configuration menu
    Copy the full SHA
    9546f19 View commit details
    Browse the repository at this point in the history