XWIKI-20616: Update jstree files and remove reference to throbber.gif

[amottier]

Jira URL

https://jira.xwiki.org/browse/XWIKI-20616

Changes

Description

• Update files provided by jstree to use the ones provided in version 3.3.16 (version of jstree referenced in the pom.xml).
• Comment out the reference to throbber.gif in jstree mixins.less file as the gif file is no part of xwiki-platform-tree-webjar and rule is override in tree.less to use spinner.gif.

Clarifications

• By looking at files such as xwiki-platform-core/xwiki-platform-tree/xwiki-platform-tree-webjar/src/main/less/jstree/mixins.less it appears they were part of version 3.3.5 or earlier (see for example this diff of src/themes/mixins.less file between version 3.3.5 and 3.3.6). As pom.xml specifies version 3.3.16 this commit update files included in xwiki-platform-tree-webjar that are coming from jstree project.
• Removing the reference to throbber.gif is a way to remove warning in the log that are probably triggered by search bot parsing the CSS. This doesn't seems to trigger any issue in XWiki with normal user interaction.

Executed Tests

./mvnw -Psnapshot,dev clean install -f xwiki-platform-core/xwiki-platform-tree/pom.xml (with Java 17 and Maven 3.9.6)

[surli]

By looking at files such as xwiki-platform-core/xwiki-platform-tree/xwiki-platform-tree-webjar/src/main/less/jstree/mixins.less it appears they were part of version 3.3.5 or earlier (see for example this diff of src/themes/mixins.less file between version 3.3.5 and 3.3.6). As pom.xml specifies version 3.3.16 this commit update files included in xwiki-platform-tree-webjar that are coming from jstree project.

@mflorea apparently you performed the upgrade from jstree 3.3.5 to 3.3.7 in ced2f2c did you forgot to update those files back then? Maybe we need some specific instructions for upgrading these?

[amottier]

@surli @mflorea is there anything I can do on my side to help the merge of this PR? Don't hesitate to reach out if I can assist. Thanks.

[mflorea]

@mflorea apparently you performed the upgrade from jstree 3.3.5 to 3.3.7 in ced2f2c did you forgot to update those files back then? Maybe we need some specific instructions for upgrading these?

@surli I did upgrade jstree from 3.3.5 to 3.3.7 but in my commit ced2f2c I updated the jstree less files (base.less and responsive.less). The problem is with the following upgrades:

• from 3.3.7 to 3.3.8 58b563c
• from 3.3.8 to 3.3.12 886cf88
• from 3.3.12 to 3.3.15 747af60
• from 3.3.15 to 3.3.16 ea115b3

which have updated only the version in the POM. So @amottier I think the best approach is to:

• make a diff between our less files after the upgrade to 3.3.7 and the original jstree 3.3.7
• apply those changes on top of the jstree 3.3.16 less files, because our jstree less files have customizations.

[mflorea]

You're removing customizations that we did on top of jstree. Unfortunately they are not marked so it's not easy to spot them unless you make a diff between our version of the jstree less files and the original jstree less files.

[amottier]

@mflorea hopefully I restored all customization that I accidentally removed. This pull request is again ready for review. Thanks for your help 👍

[mflorea]

Looks good to me. Thanks a lot for your contribution and for your patience.