Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc: Accessibility rules update #3022

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

Sereza7
Copy link
Contributor

@Sereza7 Sereza7 commented Mar 26, 2024

Changes to the status of the WCAG rules that are currently not violated. From this point on, all rules set to true will make the build fail when they are violated. The build will only fail on an accessibility regression. See the XWiki WCAG testing page for more details about the consequences of these changes.

As of https://ci.xwiki.org/job/XWiki%20Environment%20Tests/job/xwiki-platform/job/master/506/, there are only a few rules that fail through tests:

  • aria-allowed-attr 1 violation
  • label 76 violations
  • image-alt 1 violation
  • link-in-text-block 409 violations
  • select-name 2 violations
  • color-contrast 2 violations
  • scrollable-region-focusable 1 violation

Total violations: 492

  • duplicate-id fixed
  • duplicate-id-active fixed
  • duplicate-id-aria fixed

There are no additional failing types in environment test master build #506

Count of warning rules Count of failing rules
Before this PR 10 51
After this PR 7 54

This is a continuation of the process started in #2152, last step before this one was #2444.


As most of those of these errors now only have a couple violations, we can list them with their jira tickets and status at the time of writing this:

* Changes to the status of the WCAG rules that are currently not violated. From this point on, all changed rules will make the build fail.

As of https://ci.xwiki.org/job/XWiki%20Environment%20Tests/job/xwiki-platform/job/master/506/, there are only a few rules that fail through tests:
- aria-allowed-attr 1 violation
- label 76 violations
- image-alt 1 violation
- link-in-text-block 409 violations
- select-name 2 violations
- color-contrast 2 violations
- scrollable-region-focusable 1 violation

Total violations: 492

* duplicate-id fixed
* duplicate-id-active fixed
* duplicate-id-aria fixed
@vmassol
Copy link
Member

vmassol commented Mar 26, 2024

Would be nice to focus on fixing the remaining violations for:

aria-allowed-attr 1 violation
image-alt 1 violation
select-name 2 violations
color-contrast 2 violations
scrollable-region-focusable 1 violation

Since there are only a few, it should be easy and fast to fix them and thus to move these rules to error.

WDYT?

EDIT: I see above that you're planning to have almost all of them fixed soon, sounds great!

@vmassol
Copy link
Member

vmassol commented Mar 26, 2024

|  | Count of warning rules | Count of failing rules |
| ------------- | ------------- | ------------- |
| Before this PR | 10 | 51 |
| After this PR | 7 | 54 |

BTW why are there more failing rules after this PR?

@Sereza7
Copy link
Contributor Author

Sereza7 commented Apr 16, 2024

Questions discussed in the live chat :)

@michitux michitux merged commit 939db50 into xwiki:master Apr 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants