XWiki 5406 #90
Open
XWiki 5406 #90
+271
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * Password protecting the keystore. | ||
| */ | ||
| private static final String KEYSTORE_PASSWORD = "asinvESdl9csw"; |
There was a problem hiding this comment.
As far as I understand, these passwords are not really needed as the keystore is not going to be accessible anyway, being stored in a wiki permanent directory, so I just put random strings. Moreover I don't really see how we could generate and store them safely as we need them for that very purpose.
Should I let them blank or something, or is there something I'm not getting right ?
There was a problem hiding this comment.
The keystore location and password should be configured in xwiki.properties. Even if we have some defaults in there, it's better than having hard coded values in the code.
…ug fixes / minor ameliorations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the implementation of cookies for more security :
This should solve most of the issues listed in XWiki-5406 and also fix XWiki-542