Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The number of imported groups by the "LDAP Group Import" scheduler job is limited to 1000 #84

Closed
mouhb opened this issue Jan 5, 2024 · 1 comment

Comments

@mouhb
Copy link
Contributor

mouhb commented Jan 5, 2024

We configured the "LDAP User Import" Application to import all groups from an LDAP directory that contains many groups (more than 1000). The "LDAP Group Import" executed correctly but the number of imported groups was limited to 1000.

Note that the pagination of group members have been already implemented, see https://jira.xwiki.org/browse/LDAP-59, so, a new search method (searchPaginated(...)) that allows paginating the LDAP search results have been added to the class XWikiLDAPConnection , see https://github.com/xwiki-contrib/ldap/blob/ff0f33bc0213f7901798562b99e6d250b8494132/ldap-authenticator/src/main/java/org/xwiki/contrib/ldap/XWikiLDAPConnection.java#L574

So, to fix the issue the DefaultLDAPGroupImportManager#getImportableGroups(...) method should be improved to use the paginated search method here : https://github.com/xwikisas/application-ldapuserimport/blob/27505f386df0ce28131aacae604e373409e1be8c/application-ldapuserimport-api/src/main/java/com/xwiki/ldapuserimport/internal/DefaultLDAPGroupImportManager.java#L93

@mouhb
Copy link
Contributor Author

mouhb commented Jan 18, 2024

The issue have been fixed on LDAP User Import Application and the dependency to LDAP User Import Application has been upgraded to 1.5.6.

@mouhb mouhb added this to the 1.16.9 milestone Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant