Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for disabling the features that require an external server #105

Closed
mflorea opened this issue Jan 8, 2020 · 1 comment · Fixed by #157
Closed

Add support for disabling the features that require an external server #105

mflorea opened this issue Jan 8, 2020 · 1 comment · Fixed by #157

Comments

@mflorea
Copy link
Collaborator

@mflorea mflorea commented Jan 8, 2020

For those that are concerned about privacy, it should be possible to disable the features that require an external server. For this we could add a boolean (checkbox) configuration option in the Diagram administration section: "Disable features requiring an external server".

ATM this would affect the PDF export (from the diagram editor) and the image export (on IE11 only).

@oanalavinia oanalavinia self-assigned this Jun 10, 2020
oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue Jun 15, 2020
…xwikisas#105

* add a property for disabling these features in DiagramConfig and based on this stop the export of pdf from diagram editor or png / jpeg export for IE
oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue Jun 16, 2020
oanalavinia added a commit that referenced this issue Jun 16, 2020
…#105 (#157)

* add a property for disabling these features in DiagramConfig and based on this stop the export of pdf from diagram editor or png / jpeg export for IE
@oanalavinia
Copy link

@oanalavinia oanalavinia commented Jun 16, 2020

Now features that require an external server can be disabled from Diagram Config page (disableExternalServices option, which defaults to False). This option is available for each wiki where Diagram Application is installed.

As a result, by disabling it, a pop-up will be shown for export as pdf from diagram editor, or when exporting as png / jpeg in IE browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants