Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for disabling the features that require an external server #105

Closed
mflorea opened this issue Jan 8, 2020 · 1 comment · Fixed by #157
Closed

Add support for disabling the features that require an external server #105

mflorea opened this issue Jan 8, 2020 · 1 comment · Fixed by #157
Assignees
@oanalavinia
Labels
Priority: Major Type: New Feature
Milestone
1.15

Comments

@mflorea
Copy link
Collaborator

mflorea commented Jan 8, 2020

For those that are concerned about privacy, it should be possible to disable the features that require an external server. For this we could add a boolean (checkbox) configuration option in the Diagram administration section: "Disable features requiring an external server".

ATM this would affect the PDF export (from the diagram editor) and the image export (on IE11 only).
@oanalavinia oanalavinia self-assigned this Jun 10, 2020
oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue Jun 15, 2020
@oanalavinia
Add support for disabling the features that require an external server …
3fdcbf2 
…xwikisas#105

* add a property for disabling these features in DiagramConfig and based on this stop the export of pdf from diagram editor or png / jpeg export for IE
oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue Jun 16, 2020
@oanalavinia
Add support for disabling the features that require an external server …
2e82b80 
…xwikisas#105

* js escaping
oanalavinia added a commit that referenced this issue Jun 16, 2020
@oanalavinia
Add support for disabling the features that require an external server …
5a8e98c 
…#105 (#157)

* add a property for disabling these features in DiagramConfig and based on this stop the export of pdf from diagram editor or png / jpeg export for IE
@oanalavinia
Copy link

oanalavinia commented Jun 16, 2020 •
edited
Loading

Now features that require an external server can be disabled from Diagram Config page (disableExternalServices option, which defaults to False). This option is available for each wiki where Diagram Application is installed.

As a result, by disabling it, a pop-up will be shown for export as pdf from diagram editor, or when exporting as png / jpeg in IE browser.

@oanalavinia oanalavinia added this to the 1.15 milestone Jun 16, 2020
@oanalavinia oanalavinia linked a pull request Jul 22, 2020 that will close this issue
Add support for disabling the features that require an external server #105 #157
Merged
@oanalavinia oanalavinia mentioned this issue Jul 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oanalavinia oanalavinia

Labels
Priority: Major Type: New Feature
Projects
None yet
Milestone
1.15
2 participants
@mflorea @oanalavinia