Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagram print dialog box is attached to the XWiki page and not the diagram modal box #117

Closed
js-ddev opened this issue Feb 19, 2020 · 0 comments
Closed

Diagram print dialog box is attached to the XWiki page and not the diagram modal box #117

js-ddev opened this issue Feb 19, 2020 · 0 comments
Assignees
@oanalavinia
Labels
Priority: Minor Type: Bug
Milestone
1.12.3

Comments

@js-ddev
Copy link

js-ddev commented Feb 19, 2020 •
edited

Steps to reproduce on Diagram Pro extension 1.12.2 and XWiki 11:

  1. Insert a diagram in a page with some content:
    Content_page

  2. Click on the "Show" button on top of the diagram

  3. hover the modal and click on the print button

  4. With a long text and/or a small window the print box will be displayed outside of the browser window. Only the whitened background is visible. Scrolling down with the mouse or increase the size of the browser window can make the dialog box appear.
    Firefox:
    Print_dialog_box-Firefox
    Chrome:
    Print_dialog_box-Chrome

  5. Clicking on Echap key at that moment will come back to the XWiki document, with still the dialog box displayed on top of it:
    Print_dialog_box-in-content-Firefox
@oanalavinia oanalavinia self-assigned this Feb 20, 2020
oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue Feb 24, 2020
@oanalavinia
Diagram print dialog box is attached to the XWiki page and not the di…
214f5a3 
…agram modal box xwikisas#117

* fixed position of the dialog at the top of the page
@oanalavinia oanalavinia mentioned this issue Feb 24, 2020
Merged
oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue Feb 24, 2020
@oanalavinia
Diagram print dialog box is attached to the XWiki page and not the di…
2842918 
…agram modal box xwikisas#117

* code style
oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue Feb 26, 2020
@oanalavinia
Diagram print dialog box is attached to the XWiki page and not the di…
9ff6bdc 
…agram modal box xwikisas#117

* ovveride Dialog's resizeListener, which is already handled
@oanalavinia oanalavinia added this to the 1.13 milestone Feb 26, 2020
oanalavinia added a commit that referenced this issue Feb 27, 2020
@oanalavinia
Diagram print dialog box is attached to the XWiki page and not the di… (
4f87a1b 
#119)

* Diagram print dialog box is attached to the XWiki page and not the diagram modal box #117
* fixed position of the dialog at the top of the page
* ovveride Dialog's resizeListener, which is already handled
@oanalavinia oanalavinia modified the milestones: 1.13, 1.12.3 Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oanalavinia oanalavinia

Labels
Priority: Minor Type: Bug
Projects
None yet
Milestone
1.12.3
Development

No branches or pull requests
2 participants
@oanalavinia @js-ddev