Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Diagram page from template doesn't work anymore #172

Closed
CamiAndrei opened this issue Oct 15, 2020 · 5 comments
Closed

Create Diagram page from template doesn't work anymore #172

CamiAndrei opened this issue Oct 15, 2020 · 5 comments

Comments

@CamiAndrei
Copy link

Up to version 1.15.1 there was the possibility to create a diagram with "Create" -> "Diagram"
From the version 1.15.2 the Diagram Template is not visible in the list.

Version 1.15.1
Screenshot from 2020-10-15 14-28-36
Version 1.15.2
Screenshot from 2020-10-15 14-25-32

@oanalavinia oanalavinia self-assigned this Oct 16, 2020
@mflorea mflorea changed the title Create Diagrama page from template doesn't work anymore Create Diagram page from template doesn't work anymore Oct 16, 2020
@mflorea mflorea added this to the 1.15.3 milestone Oct 16, 2020
oanalavinia added a commit that referenced this issue Oct 16, 2020
* modified TemplatProvider to display the Diagram template anywere, but to make it preselected inside the Diagram space
@lucaa
Copy link

lucaa commented Nov 13, 2020

Actually, the issue was never fixed.
The change in 33b0e3e is actually only making the template available in the create forms of other paths on the wiki. However, as soon as the template is chosen , the path where the page is created changes to Diagram and setting it manually to something else does not work (there is error on creation mentioning a restriction) - which was not the behaviour on version 1.15.1 cited in the ticket.

For the actual fix: the easiest fix seems to be to add the "Use creation restrictions as suggestions" to the current settings, so that the Diagram space is only a suggestion but not a restriction. However, this would create the following interaction:

  • when you click the Diagram template, the path is changed to Diagram
  • at this point, the user can go and manually edit the path to replace Diagram with something else. This would work, it would allow the creation
    • if the user systematically wants the diagram pages to be subpages of their content pages, they need to do this everytime.
      • As opposed to other applications, in the case of the diagram application, this strategy for storage of application entries (spread in the content rather than all in the same space) is a very probable one, so creating a UI flow that is the opposite of this would be undesired.

This is not the behaviour we used to have before: before, you could just choose the Diagram template and the page was simply created in the current path. This is the desired behaviour, we should try to obtain this.

@lucaa lucaa reopened this Nov 13, 2020
@oanalavinia
Copy link

Before the upgrade to 9.11 parent there was a small app that preselected the template #13 (diagram template was available on all spaces and the app made it preselected inside Diagram space), but it was removed since it's purpose was just to be a workaround for an issue with template provider on an older version.
But it seemed like the same behavior can't be achieved only from Template Provider.
So there are 2 choices:

  1. use the suggestion of @lucaa to keep these changes + "Use creation restrictions as suggestions" , meaning that when you want to create a Diagram outside Diagram space, you have to manually change back the parent every time.
  2. add back the Default Page Template Application for having the behavior prior to this issue

@lucaa
Copy link

lucaa commented Nov 13, 2020

use the suggestion of @lucaa to keep these changes + "Use creation restrictions as suggestions" , meaning that when you want to create a Diagram outside Diagram space, you have to manually change back the parent every time.

I don't understand, I specifically asked for that to not happen (having to change the parent back every time), so at least for me that's a -1.

@oanalavinia
Copy link

oanalavinia commented Nov 13, 2020

I just wanted to underline the fact that if we don't want the outcome of the fix that you suggested, the only fix is to add back the dependency to Default Page Template Application. (until there is a way to specify from Template Provider the spaces where you want the template to be preselected)

oanalavinia added a commit that referenced this issue Nov 18, 2020
* added back application-defaultPageTemplate dependency; this is done since removing it and providing the functionality from TemplateProvider had side effects
@oanalavinia
Copy link

I added back the dependency to application-defaultPageTemplate to avoid any side effects

@oanalavinia oanalavinia modified the milestones: 1.15.3, 1.15.4 Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants